• 0 Posts
  • 53 Comments
Joined 1 year ago
cake
Cake day: June 17th, 2023

help-circle
















  • Having the e2e smokes be a requirement for PR merge is frustrating. But I’ve been on the fence before with this on my own teams. It’s enticing to have a completely “clean” main branch that has not been infested with regressions caused by a PR.

    It also gives you confidence in the crummy cases where you need to push a fix to prod right now.

    If the e2e’s flap too much, then it is not an option. I’ve tried it and it lasts one sprint before we nix it. It’s just too frustrating and development comes to a standstill.

    We have a retry policy on any smokes that need to run in a step by step order, and we aggressively prune and remove smokes that frequently fail or don’t test for real issues.

    I actually think that’s the best way to handle it.

    Who fixes the issues that the smokes find?

    On teams I’ve been on, typically a junior dev. Sounds crummy, but it actually gives them more experience with the product/code. I have been that junior dev before and I found it a positive experience.