Fix the problem with long strings by Landay7 · Pull Request #18 · mdsteele/rust-msi
github.com
Hi! Thank you for your work, I tried to play with it and figured out that there is an issue with the long string. Basically, it doesn't read fully long string and after that, all strings are messed...

Not to throw shade, just wishing that somebody here can understand. Whenever an input is reasonably long, an analyzing function will crash, and this PR aims to fix that with a mechanism that contradicts the maintainer’s understanding while a similar C implementation does not need this fix. Clearly, the maintainer has not heard a certain programming mantra…

  • tyler@programming.dev
    3·
    8 months ago

    Looks to me like a reasonable conversation is happening trying to find the underlying issue. Where is the PR being held up?

    • Aatube@kbin.melroy.orgOP
      13·
      8 months ago

      Since I posted it, the conversation has moved forward. Before that it was just two people being justifiably confused.

      • Maddier1993@programming.dev
        4·
        8 months ago

        You must understand that maintainers need to worry about supply chain attacks ever since the xz debacle. So I suggest you wait.

        • Aatube@kbin.melroy.orgOP
          1·
          8 months ago

          Thanks. All I wanted was to have someone answer with what’s actually going on, and thanks to Giooschi below that has happened, and there indeed isn’t anything to do at this point. I’ve tried to edit the post but couldn’t find a proper wording.